dma: edma: fix incorrect SG list handling
commit5fc68a6cad658e45dca3e0a6607df3a8e5df4ef9
authorSekhar Nori <nsekhar@ti.com>
Wed, 19 Mar 2014 05:55:50 +0000 (19 11:25 +0530)
committerVinod Koul <vinod.koul@intel.com>
Mon, 14 Apr 2014 03:59:55 +0000 (14 09:29 +0530)
treeab4dc89221cfeb0f7cf7c6c3551b5e2856bef6cf
parentc9eaa447e77efe77b7fa4c953bd62de8297fd6c5
dma: edma: fix incorrect SG list handling

The code to handle any length SG lists calls edma_resume()
even before edma_start() is called. This is incorrect
because edma_resume() enables edma events on the channel
after which CPU (in edma_start) cannot clear posted
events by writing to ECR (per the EDMA user's guide).

Because of this EDMA transfers fail to start if due
to some reason there is a pending EDMA event registered
even before EDMA transfers are started. This can happen if
an EDMA event is a byproduct of device initialization.

Fix this by calling edma_resume() only if it is not the
first batch of MAX_NR_SG elements.

Without this patch, MMC/SD fails to function on DA850 EVM
with DMA. The behaviour is triggered by specific IP and
this can explain why the issue was not reported before
(example with MMC/SD on AM335x).

Tested on DA850 EVM and AM335x EVM-SK using MMC/SD card.

Cc: stable@vger.kernel.org # v3.12.x+
Cc: Joel Fernandes <joelf@ti.com>
Acked-by: Joel Fernandes <joelf@ti.com>
Tested-by: Jon Ringle <jringle@gridpoint.com>
Tested-by: Alexander Holler <holler@ahsoftware.de>
Reported-by: Jon Ringle <jringle@gridpoint.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/edma.c