| commit | 571e3f3a8e6582ecce2c7fd5d0a9e2ae74cece02 | |
| author | Guenter Roeck <linux@roeck-us.net> | |
| Sun, 3 Dec 2017 23:27:56 +0000 (3 15:27 -0800) | ||
| committer | Guenter Roeck <linux@roeck-us.net> | |
| Tue, 2 Jan 2018 23:05:34 +0000 (2 15:05 -0800) | ||
| tree | 1e9fa4097eb343ac524f4e2ddc35ec5288f9ef91 | treesnapshot (tar.gz zip) |
| parent | a7a9b15a35d2504aa83e140d4cf50c85ac01e965 | commitdiff |
hwmon: (w83773g) Fix fault detection and reporting
Smatch reports:
drivers/hwmon/w83773g.c:105
get_fault() warn: shift has higher precedence than mask
Code analysis shows that the code is indeed wrong.
Fix it, and while we are at it, drop unnecessary typecast.
Fixes: 86a10c802362 ("hwmon: Add W83773G driver")
Cc: Lei YU <mine260309@gmail.com>
Reviewed-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Smatch reports:
drivers/hwmon/w83773g.c:105
get_fault() warn: shift has higher precedence than mask
Code analysis shows that the code is indeed wrong.
Fix it, and while we are at it, drop unnecessary typecast.
Fixes: 86a10c802362 ("hwmon: Add W83773G driver")
Cc: Lei YU <mine260309@gmail.com>
Reviewed-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| drivers/hwmon/w83773g.c | diffblobblamehistory |