| commit | 539012dcbdd1ff028268764385ed1f6d600812a7 | |
| author | Josh Poimboeuf <jpoimboe@redhat.com> | |
| Mon, 18 Sep 2017 19:42:09 +0000 (18 14:42 -0500) | ||
| committer | Herbert Xu <herbert@gondor.apana.org.au> | |
| Wed, 20 Sep 2017 09:42:37 +0000 (20 17:42 +0800) | ||
| tree | 70af2b7c2bebc7b31f6a0535eac4585f5fec55de | treesnapshot (tar.gz zip) |
| parent | d3dfbfe2e6e7ecd620531d5201314ad14c4ed5b3 | commitdiff |
crypto: x86/sha256-ssse3 - Fix RBP usage
Using RBP as a temporary register breaks frame pointer convention and
breaks stack traces when unwinding from an interrupt in the crypto code.
Swap the usages of R12 and RBP. Use R12 for the TBL register, and use
RBP to store the pre-aligned stack pointer.
Reported-by: Eric Biggers <ebiggers@google.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Tested-by: Eric Biggers <ebiggers@google.com>
Acked-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Using RBP as a temporary register breaks frame pointer convention and
breaks stack traces when unwinding from an interrupt in the crypto code.
Swap the usages of R12 and RBP. Use R12 for the TBL register, and use
RBP to store the pre-aligned stack pointer.
Reported-by: Eric Biggers <ebiggers@google.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Tested-by: Eric Biggers <ebiggers@google.com>
Acked-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| arch/x86/crypto/sha256-ssse3-asm.S | diffblobblamehistory |