| commit | 4f8d1bd273684385fa8e8e4f9b8bd6107016ece8 | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Sat, 16 Mar 2013 10:07:56 +0000 (16 13:07 +0300) | ||
| committer | James Bottomley <JBottomley@Parallels.com> | |
| Thu, 2 May 2013 14:37:10 +0000 (2 07:37 -0700) | ||
| tree | 733e563e854d5fd62c24d0125b1abf440f228768 | treesnapshot (tar.gz zip) |
| parent | 0a7d1d360aa3c7578deff480db080ac2544725e8 | commitdiff |
[SCSI] csiostor: off by one error
We need to store PROTO_ERR_IMPL_LOGO (26) things here, but the
first element isn't used so the array should have 27 elements.
This matches fwevt_to_rnevt[] which has 27 elements.
The patch solves a Smatch static checker warning on my system:
drivers/scsi/csiostor/csio_rnode.c:880 csio_rnode_fwevt_handler()
error: buffer overflow '(rn)->stats.n_evt_fw' 26 <= 26
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Naresh Kumar Inna <naresh@chelsio.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
We need to store PROTO_ERR_IMPL_LOGO (26) things here, but the
first element isn't used so the array should have 27 elements.
This matches fwevt_to_rnevt[] which has 27 elements.
The patch solves a Smatch static checker warning on my system:
drivers/scsi/csiostor/csio_rnode.c:880 csio_rnode_fwevt_handler()
error: buffer overflow '(rn)->stats.n_evt_fw' 26 <= 26
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Naresh Kumar Inna <naresh@chelsio.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| drivers/scsi/csiostor/csio_lnode.h | diffblobblamehistory | |
| drivers/scsi/csiostor/csio_rnode.h | diffblobblamehistory |