| commit | 45bfbc013b4294cadafbef821d377d3a99c7ab1e | |
| author | Colin Ian King <colin.king@canonical.com> | |
| Sun, 1 Oct 2017 16:27:35 +0000 (1 17:27 +0100) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 2 Oct 2017 06:05:54 +0000 (1 23:05 -0700) | ||
| tree | 08eef6b65e4e5aaa4c83841fd152072b727f1982 | treesnapshot (tar.gz zip) |
| parent | ed36edf870d447b4ab7cbd217ba5c6600f20e32d | commitdiff |
mlxsw: spectrum: fix uninitialized value in err
In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all
values of i from 0 to MAXIVS-1, the err is not set at all and hence
has a garbage value on the error return at the end of the function,
so initialize it to 0. Also, the error return check on err and goto
to err: inside the for loop makes it impossible for err to be zero
at the end of the for loop, so we can remove the redundant err check
at the end of the loop.
Detected by CoverityScan CID#1457207 ("Unitialized scalar value")
Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading logic")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Yotam Gigi <yotamg@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all
values of i from 0 to MAXIVS-1, the err is not set at all and hence
has a garbage value on the error return at the end of the function,
so initialize it to 0. Also, the error return check on err and goto
to err: inside the for loop makes it impossible for err to be zero
at the end of the for loop, so we can remove the redundant err check
at the end of the loop.
Detected by CoverityScan CID#1457207 ("Unitialized scalar value")
Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading logic")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Yotam Gigi <yotamg@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/mellanox/mlxsw/spectrum_mr.c | diffblobblamehistory |