| commit | 34ff1bf4920471cff66775dc39537b15c5f0feff | |
| author | Colin Ian King <colin.king@canonical.com> | |
| Fri, 18 Aug 2017 13:34:16 +0000 (18 14:34 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Sun, 20 Aug 2017 18:08:41 +0000 (20 11:08 -0700) | ||
| tree | c544b6700149cc5133e22f3c3a93c7f761d61d2a | treesnapshot (tar.gz zip) |
| parent | 6feb5c82de6fba4dbf1db166fa8d78ca5f4b7b34 | commitdiff |
staging/rts5208: fix incorrect shift to extract upper nybble
The mask of sns_key_info1 suggests the upper nybble is being extracted
however the following shift of 8 bits is too large and always results in
0. Fix this by shifting only by 4 bits to correctly get the upper nybble.
Detected by CoverityScan, CID#142891 ("Operands don't affect result")
Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
The mask of sns_key_info1 suggests the upper nybble is being extracted
however the following shift of 8 bits is too large and always results in
0. Fix this by shifting only by 4 bits to correctly get the upper nybble.
Detected by CoverityScan, CID#142891 ("Operands don't affect result")
Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| drivers/staging/rts5208/rtsx_scsi.c | diffblobblamehistory |