| commit | 30bcb039d573356170ba26e829eba9a4b1ce3048 | |
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | |
| Tue, 4 Mar 2014 18:30:02 +0000 (4 11:30 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Fri, 7 Mar 2014 01:06:16 +0000 (6 17:06 -0800) | ||
| tree | 17fe56a8c7f3b2c6fbf9d4c6c4935fadd370dd87 | treesnapshot (tar.gz zip) |
| parent | 937a3706880c9bd3ff106cba296ce7bf751951f2 | commitdiff |
staging: comedi: pcl812: tidy up the analog input (*insn_read)
For aesthetics, move this function out of the async command support
code.
For safety, the INT request (end-of-conversion flag) should be cleared
before doing each conversion and after the final data sample is read.
The driver currently does not do this.
Refactor the function a bit so it's more like the pcl818 and pcl816
drivers and use common code to clear the flag for a timeout and after
the last sample.
Do a bit of other tidying up during the move.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
For aesthetics, move this function out of the async command support
code.
For safety, the INT request (end-of-conversion flag) should be cleared
before doing each conversion and after the final data sample is read.
The driver currently does not do this.
Refactor the function a bit so it's more like the pcl818 and pcl816
drivers and use common code to clear the flag for a timeout and after
the last sample.
Do a bit of other tidying up during the move.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| drivers/staging/comedi/drivers/pcl812.c | diffblobblamehistory |