| commit | 2b999ba899059eed00a03d029894a62486e7e2bc | |
| author | Antoine Tenart <antoine.tenart@bootlin.com> | |
| Fri, 4 May 2018 15:21:03 +0000 (4 17:21 +0200) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 9 May 2018 00:14:27 +0000 (8 20:14 -0400) | ||
| tree | a369534f52328b890e90f02b05d2aea6a337427e | treesnapshot (tar.gz zip) |
| parent | 8d42eada64e4c564d22be61ef68585d4bbaabaa9 | commitdiff |
net: phy: sfp: handle cases where neither BR, min nor BR, max is given
When computing the bitrate using values read from an SFP module EEPROM,
we use the nominal BR plus BR,min and BR,max to determine the
boundaries. But in some cases BR,min and BR,max aren't provided, which
led the SFP code to end up having the nominal value for both the minimum
and maximum bitrate values. When using a passive cable, the nominal
value should be used as the maximum one, and there is no minimum one
so we should use 0.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
When computing the bitrate using values read from an SFP module EEPROM,
we use the nominal BR plus BR,min and BR,max to determine the
boundaries. But in some cases BR,min and BR,max aren't provided, which
led the SFP code to end up having the nominal value for both the minimum
and maximum bitrate values. When using a passive cable, the nominal
value should be used as the maximum one, and there is no minimum one
so we should use 0.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/phy/sfp-bus.c | diffblobblamehistory |