| commit | 260dd2c3e2aeefbe78065f0737dceae1ceb1196a | |
| author | Eric Dumazet <edumazet@google.com> | |
| Thu, 27 Sep 2018 16:31:55 +0000 (27 09:31 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 28 Sep 2018 18:12:29 +0000 (28 11:12 -0700) | ||
| tree | a33c30a777b2afe3b5fff357cc2e567124ba5ca1 | treesnapshot (tar.gz zip) |
| parent | 4bd2c03be707253f1157bd759fdd6971e4f70403 | commitdiff |
virtio_net: remove ndo_poll_controller
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
virto_net uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
virto_net uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/virtio_net.c | diffblobblamehistory |