| commit | 22d97e561dac6cc90954567a7b4be54680982769 | |
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | |
| Thu, 30 Jan 2014 20:17:42 +0000 (30 17:17 -0300) | ||
| committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | |
| Sun, 25 May 2014 16:02:05 +0000 (25 13:02 -0300) | ||
| tree | 81d669003e902294456012a95b45f4fd349d662b | treesnapshot (tar.gz zip) |
| parent | 05cacb176712cbbd3ae0331d92fe57741ef2d2ba | commitdiff |
[media] adv7604: Replace *_and_or() functions with *_clr_set()
The *_and_or() functions take an 'and' bitmask to be ANDed with the
register value before ORing it with th 'or' bitmask. As the functions
are used to mask and set bits selectively, this requires the caller to
invert the 'and' bitmask and is thus error prone. Replace those
functions with a *_clr_set() variant that takes a mask of bits to be
cleared instead of a mask of bits to be kept.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
The *_and_or() functions take an 'and' bitmask to be ANDed with the
register value before ORing it with th 'or' bitmask. As the functions
are used to mask and set bits selectively, this requires the caller to
invert the 'and' bitmask and is thus error prone. Replace those
functions with a *_clr_set() variant that takes a mask of bits to be
cleared instead of a mask of bits to be kept.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
| drivers/media/i2c/adv7604.c | diffblobblamehistory |