| commit | 226a2dd62c5d789088fcf7804fbe5613887870a5 | |
| author | Eric Dumazet <edumazet@google.com> | |
| Thu, 27 Sep 2018 16:31:53 +0000 (27 09:31 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 28 Sep 2018 18:12:28 +0000 (28 11:12 -0700) | ||
| tree | adfbcbfccb4b9b33bc5b540e3a48fa0a516ea647 | treesnapshot (tar.gz zip) |
| parent | e71fb423e0dea3c9f98f0101e965426edfe849cd | commitdiff |
ehea: remove ndo_poll_controller
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
ehea uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Douglas Miller <dougmill@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
ehea uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Douglas Miller <dougmill@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/ibm/ehea/ehea_main.c | diffblobblamehistory |