| commit | 20f0170377264e8449b6987041f0bcc4d746d3ed | |
| author | Eric Dumazet <edumazet@google.com> | |
| Wed, 24 Jul 2013 00:15:54 +0000 (23 17:15 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 26 Jul 2013 20:48:22 +0000 (26 13:48 -0700) | ||
| tree | 5bd52502d56878edd5710bb4c650d717ef26a1a0 | treesnapshot (tar.gz zip) |
| parent | 1df86b4ceec84dbf264fbeada9e2afff5e86c2c9 | commitdiff |
usbnet: do not pretend to support SG/TSO
usbnet doesn't support yet SG, so drivers should not advertise SG or TSO
capabilities, as they allow TCP stack to build large TSO packets that
need to be linearized and might use order-5 pages.
This adds an extra copy overhead and possible allocation failures.
Current code ignore skb_linearize() return code so crashes are even
possible.
Best is to not pretend SG/TSO is supported, and add this again when/if
usbnet really supports SG for devices who could get a performance gain.
Based on a prior patch from Freddy Xin <freddy@asix.com.tw>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
usbnet doesn't support yet SG, so drivers should not advertise SG or TSO
capabilities, as they allow TCP stack to build large TSO packets that
need to be linearized and might use order-5 pages.
This adds an extra copy overhead and possible allocation failures.
Current code ignore skb_linearize() return code so crashes are even
possible.
Best is to not pretend SG/TSO is supported, and add this again when/if
usbnet really supports SG for devices who could get a performance gain.
Based on a prior patch from Freddy Xin <freddy@asix.com.tw>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/usb/ax88179_178a.c | diffblobblamehistory | |
| drivers/net/usb/smsc75xx.c | diffblobblamehistory |