usb: gadget: fix error return code
commit20e7d4653d2b580e490dfbb1dfd138cd9844319c
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 7 Aug 2014 20:57:47 +0000 (7 22:57 +0200)
committerFelipe Balbi <balbi@ti.com>
Tue, 19 Aug 2014 14:24:33 +0000 (19 09:24 -0500)
treec9ab22e5ff0e1c9d2159518f974b6e7527d62f97
parentbbc66e140babbc7026fa07478b588f2b56f99751
usb: gadget: fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/fusb300_udc.c