| commit | 127005717dfc5bf42091a14e5a9736f52bfaea1c | |
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | |
| Tue, 4 Mar 2014 18:29:33 +0000 (4 11:29 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Fri, 7 Mar 2014 01:06:11 +0000 (6 17:06 -0800) | ||
| tree | a39b096691b042ec3ad62a61012644511f7dbb8c | treesnapshot (tar.gz zip) |
| parent | db0446d0e2a059d3961210664a08dcd8104e448b | commitdiff |
staging: comedi: pcl818: interrupt handlers should not busywait
The interrupt is only generated by the hardware at the completion of
an A/D conversion. Because of this the sanity check to make sure that
the A/D conversion is complete and data is available is probably
unnecessary but it doesn't hurt anything.
The busywait loop is a different issue. Interrupt routines should not
busywait. That's just mean...
Remove the bustwait and use pcl818_ai_eoc() to check for the end-of-
conversion.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
The interrupt is only generated by the hardware at the completion of
an A/D conversion. Because of this the sanity check to make sure that
the A/D conversion is complete and data is available is probably
unnecessary but it doesn't hurt anything.
The busywait loop is a different issue. Interrupt routines should not
busywait. That's just mean...
Remove the bustwait and use pcl818_ai_eoc() to check for the end-of-
conversion.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| drivers/staging/comedi/drivers/pcl818.c | diffblobblamehistory |