| commit | 126f760ca94dae77425695f9f9238b731de86e32 | |
| author | Håkon Bugge <Haakon.Bugge@oracle.com> | |
| Wed, 6 Sep 2017 16:35:51 +0000 (6 18:35 +0200) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 8 Sep 2017 03:07:13 +0000 (7 20:07 -0700) | ||
| tree | 9eb6678bb969d67a8f6cbab6110f0816bbde0798 | treesnapshot (tar.gz zip) |
| parent | eef5a7cc2a571eb2176c8b9260d4ccfc9f6be127 | commitdiff |
rds: Fix incorrect statistics counting
In rds_send_xmit() there is logic to batch the sends. However, if
another thread has acquired the lock and has incremented the send_gen,
it is considered a race and we yield. The code incrementing the
s_send_lock_queue_raced statistics counter did not count this event
correctly.
This commit counts the race condition correctly.
Changes from v1:
- Removed check for *someone_on_xmit()*
- Fixed incorrect indentation
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Knut Omang <knut.omang@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
In rds_send_xmit() there is logic to batch the sends. However, if
another thread has acquired the lock and has incremented the send_gen,
it is considered a race and we yield. The code incrementing the
s_send_lock_queue_raced statistics counter did not count this event
correctly.
This commit counts the race condition correctly.
Changes from v1:
- Removed check for *someone_on_xmit()*
- Fixed incorrect indentation
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Knut Omang <knut.omang@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/rds/send.c | diffblobblamehistory |