| commit | 0fb6a55cc31ff216ef86332404ad3e425cb669eb | |
| author | Emil Tantilov <emil.s.tantilov@intel.com> | |
| Thu, 4 Dec 2014 03:03:38 +0000 (4 03:03 +0000) | ||
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | |
| Fri, 5 Dec 2014 17:13:08 +0000 (5 09:13 -0800) | ||
| tree | f3e0e75d706cca8f6caf9eee77f8a33c60dd625c | treesnapshot (tar.gz zip) |
| parent | 9be4a9bb34746b8b87b6361462484ca42ac7089e | commitdiff |
ixgbe: fix crash on rmmod after probe fail
The driver has logic to free up used data in case any of the checks in
ixgbe_probe() fail, however there is a similar set of cleanups that can
occur on driver unload in ixgbe_remove() which can cause the rmmod command
to crash.
This patch aims to fix the logic by moving pci_set_drvdata() after all error
checks and then adds a check in ixgbe_remove() to skip it altogether if
adapter comes up empty.
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
The driver has logic to free up used data in case any of the checks in
ixgbe_probe() fail, however there is a similar set of cleanups that can
occur on driver unload in ixgbe_remove() which can cause the rmmod command
to crash.
This patch aims to fix the logic by moving pci_set_drvdata() after all error
checks and then adds a check in ixgbe_remove() to skip it altogether if
adapter comes up empty.
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
| drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | diffblobblamehistory |