| commit | d80cba6c53621ecdd768035f2988dc99addf12c2 | |
| author | Julia Lawall <julia@diku.dk> | |
| Mon, 22 Aug 2011 14:00:35 +0000 (22 16:00 +0200) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 22 Aug 2011 23:07:40 +0000 (22 16:07 -0700) | ||
| tree | 0c0e14af15129d3c9d48694b4ac9f7b2c2b128c3 | treesnapshot (tar.gz zip) |
| parent | e18a99e28fe308f0028be8644418a1ac653a2a96 | commitdiff |
drivers/usb/host/ohci-omap3.c: test the just-initialized value
Test the just-initialized value rather than some other one.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
statement S;
@@
x = f(...);
(
if (\(x == NULL\|IS_ERR(x)\)) S
|
*if (\(y == NULL\|IS_ERR(y)\))
{ ... when != x
return ...; }
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Test the just-initialized value rather than some other one.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
statement S;
@@
x = f(...);
(
if (\(x == NULL\|IS_ERR(x)\)) S
|
*if (\(y == NULL\|IS_ERR(y)\))
{ ... when != x
return ...; }
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/usb/host/ohci-omap3.c | diffblobblamehistory |