| commit | d62668e1dd830a81ef73ec73386b420cb2a9ca62 | |
| author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | |
| Wed, 11 Nov 2009 22:26:50 +0000 (11 14:26 -0800) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Thu, 12 Nov 2009 15:26:00 +0000 (12 07:26 -0800) | ||
| tree | 9121a24fe3a04279c374e813342661c16928ea3c | treesnapshot (tar.gz zip) |
| parent | bcb3a1676b87effbdeffe8da5c44f63433d158d9 | commitdiff |
gpiolib: fix device_create() result check
In case of failure, device_create() returns not NULL but the error code.
The current code checks for non-NULL though which causes kernel oops in
sysfs_create_group() when device_create() fails. Check for error using
IS_ERR() and propagate the error value using PTR_ERR() instead of fixed
-ENODEV code returned now...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
In case of failure, device_create() returns not NULL but the error code.
The current code checks for non-NULL though which causes kernel oops in
sysfs_create_group() when device_create() fails. Check for error using
IS_ERR() and propagate the error value using PTR_ERR() instead of fixed
-ENODEV code returned now...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| drivers/gpio/gpiolib.c | diffblobblamehistory |