| commit | d6042eac44b54dc5c7cb839175eb51dfd03d7633 | |
| author | Al Viro <viro@ZenIV.linux.org.uk> | |
| Wed, 4 Jan 2012 10:51:03 +0000 (4 10:51 +0000) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Wed, 4 Jan 2012 23:03:06 +0000 (4 15:03 -0800) | ||
| tree | b2a1c5878771f4d7a5aada868bdbc7eafc4eba3b | treesnapshot (tar.gz zip) |
| parent | 8a88951b5878dc475dcd841cefc767e36397d14e | commitdiff |
minixfs: misplaced checks lead to dentry leak
bitmap size sanity checks should be done *before* allocating ->s_root;
there their cleanup on failure would be correct. As it is, we do iput()
on root inode, but leak the root dentry...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Josh Boyer <jwboyer@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
bitmap size sanity checks should be done *before* allocating ->s_root;
there their cleanup on failure would be correct. As it is, we do iput()
on root inode, but leak the root dentry...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Josh Boyer <jwboyer@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| fs/minix/inode.c | diffblobblamehistory |