| commit | c1804d547dc098363443667609c272d1e4d15ee8 | |
| author | Oleg Nesterov <oleg@redhat.com> | |
| Mon, 15 Mar 2010 09:10:14 +0000 (15 10:10 +0100) | ||
| committer | Ingo Molnar <mingo@elte.hu> | |
| Fri, 2 Apr 2010 18:12:02 +0000 (2 20:12 +0200) | ||
| tree | c05ecb82cfb14b550c8d2242f5b0d4ad7e87bc52 | treesnapshot (tar.gz zip) |
| parent | 1445c08d06c5594895b4fae952ef8a457e89c390 | commitdiff |
sched: move_task_off_dead_cpu(): Remove retry logic
The previous patch preserved the retry logic, but it looks unneeded.
__migrate_task() can only fail if we raced with migration after we dropped
the lock, but in this case the caller of set_cpus_allowed/etc must initiate
migration itself if ->on_rq == T.
We already fixed p->cpus_allowed, the changes in active/online masks must
be visible to racer, it should migrate the task to online cpu correctly.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100315091014.GA9138@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
The previous patch preserved the retry logic, but it looks unneeded.
__migrate_task() can only fail if we raced with migration after we dropped
the lock, but in this case the caller of set_cpus_allowed/etc must initiate
migration itself if ->on_rq == T.
We already fixed p->cpus_allowed, the changes in active/online masks must
be visible to racer, it should migrate the task to online cpu correctly.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100315091014.GA9138@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| kernel/sched.c | diffblobblamehistory |