| commit | ba1bf474eae07a128fae6252bf7d68eaef0eacf8 | |
| author | David Ward <david.ward@ll.mit.edu> | |
| Thu, 13 Sep 2012 05:22:35 +0000 (13 05:22 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 13 Sep 2012 20:10:13 +0000 (13 16:10 -0400) | ||
| tree | b26f1d2656b2659935eff175c168604753f7a5e9 | treesnapshot (tar.gz zip) |
| parent | 1fe37b106b039d9358fd1211c39b1fa199e547a8 | commitdiff |
net_sched: gred: actually perform idling in WRED mode
gred_dequeue() and gred_drop() do not seem to get called when the
queue is empty, meaning that we never start idling while in WRED
mode. And since qidlestart is not stored by gred_store_wred_set(),
we would never stop idling while in WRED mode if we ever started.
This messes up the average queue size calculation that influences
packet marking/dropping behavior.
Now, we start WRED mode idling as we are removing the last packet
from the queue. Also we now actually stop WRED mode idling when we
are enqueuing a packet.
Cc: Bruce Osler <brosler@cisco.com>
Signed-off-by: David Ward <david.ward@ll.mit.edu>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
gred_dequeue() and gred_drop() do not seem to get called when the
queue is empty, meaning that we never start idling while in WRED
mode. And since qidlestart is not stored by gred_store_wred_set(),
we would never stop idling while in WRED mode if we ever started.
This messes up the average queue size calculation that influences
packet marking/dropping behavior.
Now, we start WRED mode idling as we are removing the last packet
from the queue. Also we now actually stop WRED mode idling when we
are enqueuing a packet.
Cc: Bruce Osler <brosler@cisco.com>
Signed-off-by: David Ward <david.ward@ll.mit.edu>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/sched/sch_gred.c | diffblobblamehistory |