| commit | a1edf9cf6d1efed2981fcf6e4caa704fbb1bd093 | |
| author | Andy Grover <agrover@redhat.com> | |
| Thu, 9 Feb 2012 20:18:06 +0000 (9 12:18 -0800) | ||
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | |
| Sat, 25 Feb 2012 22:37:48 +0000 (25 14:37 -0800) | ||
| tree | e9b0c6585a2028844d790efae0bf3ca15e4276cf | treesnapshot (tar.gz zip) |
| parent | 16786454acec0e0e55e32d508b3058b32c1f23f3 | commitdiff |
target: Cleanup transport_kunmap_data_sg()
This code isn't broken per se, but it's scary to look at! It looks like
in the t_data_nents==1 case we're doing both a kunmap and a vunmap,
what's saving us is that t_data_vmap in this case is 0, so vunmap
doesn't do anything.
Return after kunmap, so the handling of the three cases does not overlap.
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This code isn't broken per se, but it's scary to look at! It looks like
in the t_data_nents==1 case we're doing both a kunmap and a vunmap,
what's saving us is that t_data_vmap in this case is 0, so vunmap
doesn't do anything.
Return after kunmap, so the handling of the three cases does not overlap.
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| drivers/target/target_core_transport.c | diffblobblamehistory |