| commit | 955b44304afca143b82304fe421e990ec607834a | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Sat, 10 Mar 2012 07:58:18 +0000 (10 04:58 -0300) | ||
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | |
| Mon, 19 Mar 2012 18:45:01 +0000 (19 15:45 -0300) | ||
| tree | f0046ed726b7c677d6d70d256c816573cb503932 | treesnapshot (tar.gz zip) |
| parent | 23bfb5be9f4c14937d70ed09f24a19d86df1951b | commitdiff |
[media] gpio-ir-recv: a couple signedness bugs
There are couple places where we check unsigned values for negative. I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
if (pdata->gpio_nr < 0)
return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative
returns.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
There are couple places where we check unsigned values for negative. I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
if (pdata->gpio_nr < 0)
return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative
returns.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| drivers/media/rc/gpio-ir-recv.c | diffblobblamehistory | |
| include/media/gpio-ir-recv.h | diffblobblamehistory |