| commit | 87e3c0553fcbea79bf9f17fc5694484ecf3ae5e8 | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 1 Feb 2012 07:46:20 +0000 (1 10:46 +0300) | ||
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | |
| Mon, 6 Feb 2012 23:47:59 +0000 (6 18:47 -0500) | ||
| tree | 7d0dcc070b4fdb9cbb7defa212feb4ba82519a26 | treesnapshot (tar.gz zip) |
| parent | b01dd1d8fae6178cbec374b90da2e4a3b8dce9ba | commitdiff |
SUNRPC: remove an unneeded NULL check in xprt_connect()
We check "task->tk_rqstp" and then we dereference it without checking on
the next line. The only caller is call_connect() and that has a check
which prevents it from calling xprt_connect() with a NULL.
if (task->tk_status < 0)
return;
If "task->tk_rqstp" were NULL then "tk_status" would be -EAGAIN.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
We check "task->tk_rqstp" and then we dereference it without checking on
the next line. The only caller is call_connect() and that has a check
which prevents it from calling xprt_connect() with a NULL.
if (task->tk_status < 0)
return;
If "task->tk_rqstp" were NULL then "tk_status" would be -EAGAIN.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
| net/sunrpc/xprt.c | diffblobblamehistory |