| commit | 63002e84a80c02b0be0f73932b955755903baabf | |
| author | Guenter Roeck <linux@roeck-us.net> | |
| Fri, 24 Aug 2012 03:08:49 +0000 (23 20:08 -0700) | ||
| committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | |
| Mon, 27 Aug 2012 16:37:52 +0000 (27 09:37 -0700) | ||
| tree | 4e14dc4afd02f063daab3f36dd56849b472697b5 | treesnapshot (tar.gz zip) |
| parent | c68025bf0363a7b44be2de512a88a57d57e63d81 | commitdiff |
spi/topcliff-pch: Fix device remove function
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which results in
device memory being freed. An extra call to spi_master_put is unnecessary
and results in an access to free memory. Drop it.
Also, the device subsystem resets device driver data to NULL after the call to
the remove function returns, so there is no need to do it here.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which results in
device memory being freed. An extra call to spi_master_put is unnecessary
and results in an access to free memory. Drop it.
Also, the device subsystem resets device driver data to NULL after the call to
the remove function returns, so there is no need to do it here.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
| drivers/spi/spi-topcliff-pch.c | diffblobblamehistory |