| commit | 54bd5206bf1615eadee5b87c64252c6991d737dc | |
| author | Ilija Hadzic <ihadzic@research.bell-labs.com> | |
| Wed, 26 Oct 2011 19:43:58 +0000 (26 15:43 -0400) | ||
| committer | Dave Airlie <airlied@redhat.com> | |
| Tue, 1 Nov 2011 16:02:10 +0000 (1 16:02 +0000) | ||
| tree | 7f4a198f3e8114cc4910bce5666a9848c2a3af96 | treesnapshot (tar.gz zip) |
| parent | 77b1bad423599c9841ea282a82172f039bb2ff92 | commitdiff |
drm/radeon/kms: use defined constants for crtc/hpd count instead of hard-coded value 6
radeon_driver_irq_preinstall_kms and radeon_driver_irq_uninstall_kms
hard code the loop to 6 which happens to be the current maximum
number of crtcs and hpd pins; if one day an ASIC with more crtcs
(or hpd pins) comes out, this is a trouble waiting to happen.
introduce constants for maximum CRTC count, maximum HPD pins count
and maximum HDMI blocks count (per FIXME in radeon_irq structure)
and correct the loops in radeon_driver_irq_preinstall_kms and
radeon_driver_irq_uninstall_kms
v2: take care of goofs pointed out by Alex Deucher
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
radeon_driver_irq_preinstall_kms and radeon_driver_irq_uninstall_kms
hard code the loop to 6 which happens to be the current maximum
number of crtcs and hpd pins; if one day an ASIC with more crtcs
(or hpd pins) comes out, this is a trouble waiting to happen.
introduce constants for maximum CRTC count, maximum HPD pins count
and maximum HDMI blocks count (per FIXME in radeon_irq structure)
and correct the loops in radeon_driver_irq_preinstall_kms and
radeon_driver_irq_uninstall_kms
v2: take care of goofs pointed out by Alex Deucher
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| drivers/gpu/drm/radeon/radeon.h | diffblobblamehistory | |
| drivers/gpu/drm/radeon/radeon_irq_kms.c | diffblobblamehistory |