| commit | 3ff5588d3f8afad65ded52ac0e4191462fe034cb | |
| author | Alan Stern <stern@rowland.harvard.edu> | |
| Tue, 7 Sep 2010 15:44:01 +0000 (7 11:44 -0400) | ||
| committer | James Bottomley <James.Bottomley@suse.de> | |
| Tue, 21 Dec 2010 18:23:52 +0000 (21 12:23 -0600) | ||
| tree | d75858a35c3f9042dc234e17772fe9d713e2ca9c | treesnapshot (tar.gz zip) |
| parent | 29687512c0b084957112cc2c0743ce34cd0d5055 | commitdiff |
[SCSI] sd: improve logic and efficiecy of media-change detection
This patch (as1415) improves the formerly incomprehensible logic in
sd_media_changed() (the current code refers to "changed" as a state,
whereas in fact it is a relation between two states). It also adds a
big comment so that everyone can understand what is really going on.
The patch also improves efficiency by not reporting a media change
when no medium was ever present. If no medium was present the last
time we checked and there's still no medium, it's not necessary to
tell the caller that a change occurred. Doing so merely causes the
caller to attempt to revalidate a non-existent disk, which is a waste
of time.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This patch (as1415) improves the formerly incomprehensible logic in
sd_media_changed() (the current code refers to "changed" as a state,
whereas in fact it is a relation between two states). It also adds a
big comment so that everyone can understand what is really going on.
The patch also improves efficiency by not reporting a media change
when no medium was ever present. If no medium was present the last
time we checked and there's still no medium, it's not necessary to
tell the caller that a change occurred. Doing so merely causes the
caller to attempt to revalidate a non-existent disk, which is a waste
of time.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
| drivers/scsi/sd.c | diffblobblamehistory |