| commit | 3515d0161d55d2fa1a340932625f94240a68c262 | |
| author | Al Viro <viro@parcelfarce.linux.theplanet.co.uk> | |
| Thu, 25 Aug 2005 22:13:14 +0000 (25 23:13 +0100) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Fri, 26 Aug 2005 23:30:30 +0000 (26 16:30 -0700) | ||
| tree | 986c5aa31761cbc186b4de7b410d539633f5ceb1 | treesnapshot (tar.gz zip) |
| parent | a46206e74e1897bf34d6b58f0991a0d6f3797e27 | commitdiff |
[PATCH] late spinlock initialization in ieee1394/ohci
spinlock used in irq handler should be initialized before registering
irq, even if we know that our device has interrupts disabled; handler
is registered shared and taking spinlock is done unconditionally. As
it is, we can and do get oopsen on boot for some configuration, depending
on irq routing - I've got a reproducer.
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Ben Collins <bcollins@debian.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
spinlock used in irq handler should be initialized before registering
irq, even if we know that our device has interrupts disabled; handler
is registered shared and taking spinlock is done unconditionally. As
it is, we can and do get oopsen on boot for some configuration, depending
on irq routing - I've got a reproducer.
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Ben Collins <bcollins@debian.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| drivers/ieee1394/ohci1394.c | diffblobblamehistory |