| commit | 027a3b617c5490b5287d98921675abcbebeb32df | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 9 Feb 2012 00:49:34 +0000 (9 00:49 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 9 Feb 2012 20:43:30 +0000 (9 15:43 -0500) | ||
| tree | 5c00f54e4e20b7f687c10c1392ad476e8eabab4d | treesnapshot (tar.gz zip) |
| parent | 5a46e0f95664bb65e3256f3c53b14b8a627c656b | commitdiff |
bna: fix error handling of bnad_get_flash_partition_by_offset()
The current error handling doesn't work because we flash_part is a u32
so the checks for negative error codes don't work. I considered making
things signed but I don't know the hardware enough to say if that's a
problem. Really, we don't use the error codes so just returning zero
for all problems is fine.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The current error handling doesn't work because we flash_part is a u32
so the checks for negative error codes don't work. I considered making
things signed but I don't know the hardware enough to say if that's a
problem. Really, we don't use the error codes so just returning zero
for all problems is fine.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/brocade/bna/bnad_ethtool.c | diffblobblamehistory |