knfsd: fix spurious EINVAL errors on first access of new filesystem
commitf25808c845cab29abf45879276708cb859183d62
authorGreg KH <gregkh@suse.de>
Fri, 22 Feb 2008 21:31:29 +0000 (22 13:31 -0800)
committerOliver Pinter <oliver.pntr@gmail.com>
Sat, 23 Feb 2008 20:05:18 +0000 (23 21:05 +0100)
tree3168c8a638e140daaa68d0654a8c3cc3ce4f8b59
parenta4d8f9d56584586057db74fd9c5c53df0eb058bd
knfsd: fix spurious EINVAL errors on first access of new filesystem

2.6.22-stable review patch.  If anyone has any objections, please let us
know.

------------------

From: J. Bruce Fields <bfields@citi.umich.edu>

mainline: ac8587dcb58e40dd336d99d60f852041e06cc3dd

The v2/v3 acl code in nfsd is translating any return from fh_verify() to
nfserr_inval.  This is particularly unfortunate in the case of an
nfserr_dropit return, which is an internal error meant to indicate to
callers that this request has been deferred and should just be dropped
pending the results of an upcall to mountd.

Thanks to Roland <devzero@web.de> for bug report and data collection.

Cc: Roland <devzero@web.de>
Acked-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Reviewed-By: NeilBrown <neilb@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
CC: Oliver Pinter <oliver.pntr@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
fs/nfsd/nfs2acl.c
fs/nfsd/nfs3acl.c