Fix buffer overflow if server sends corrupt response to small
commit982b92285ec9f45e1658c95376f9e1a47ba47090
authorSteve French <sfrench@us.ibm.com>
Tue, 13 Nov 2007 22:41:37 +0000 (13 22:41 +0000)
committerOliver Pinter <oliver.pntr@gmail.com>
Sat, 29 Mar 2008 15:18:50 +0000 (29 16:18 +0100)
tree6cacdb758541a93f6b77e4916fe47f69bc332735
parent54ddb8eee828607fb70a553b9473fe671fc2c87e
Fix buffer overflow if server sends corrupt response to small

[CIFS] Fix buffer overflow if server sends corrupt response to small
request

In SendReceive() function in transport.c - it memcpy's
message payload into a buffer passed via out_buf param. The function
assumes that all buffers are of size (CIFSMaxBufSize +
MAX_CIFS_HDR_SIZE) , unfortunately it is also called with smaller
(MAX_CIFS_SMALL_BUFFER_SIZE) buffers.  There are eight callers
(SMB worker functions) which are primarily affected by this change:

TreeDisconnect, uLogoff, Close, findClose, SetFileSize, SetFileTimes,
Lock and PosixLock

CC: Dave Kleikamp <shaggy@austin.ibm.com>
CC: Przemyslaw Wegrzyn <czajnik@czajsoft.pl>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Acked-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
fs/cifs/cifsglob.h
fs/cifs/cifsproto.h
fs/cifs/cifssmb.c
fs/cifs/connect.c
fs/cifs/file.c
fs/cifs/sess.c
fs/cifs/transport.c