genirq: do not leave interupts enabled on free_irq
commit853c342ffcde7ca697f4b7950aa2a12f1752fce1
authorThomas Gleixner <tglx@linutronix.de>
Tue, 19 Feb 2008 23:29:02 +0000 (20 00:29 +0100)
committerOliver Pinter <oliver.pntr@gmail.com>
Tue, 4 Mar 2008 17:09:29 +0000 (4 18:09 +0100)
tree9dd7cacf84e0adc49c995deaa7a675de39541c23
parent55f2876a0023596d6b27e20b0c806654b38ccfae
genirq: do not leave interupts enabled on free_irq

commit 89d694b9dbe769ca1004e01db0ca43964806a611

The default_disable() function was changed in commit:

 76d2160147f43f982dfe881404cfde9fd0a9da21
 genirq: do not mask interrupts by default

It removed the mask function in favour of the default delayed
interrupt disabling. Unfortunately this also broke the shutdown in
free_irq() when the last handler is removed from the interrupt for
those architectures which rely on the default implementations. Now we
can end up with a enabled interrupt line after the last handler was
removed, which can result in spurious interrupts.

Fix this by adding a default_shutdown function, which is only
installed, when the irqchip implementation does provide neither a
shutdown nor a disable function.

Pointed-out-by: Michael Hennerich <Michael.Hennerich@analog.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Tested-by: Michael Hennerich <Michael.Hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
kernel/irq/chip.c