| commit | 6d3baf2eb8bd680b2d4f509bc3dbf4dcd6e27a40 | |
| author | NeilBrown <neilb@suse.de> | |
| Mon, 5 Mar 2007 08:30:44 +0000 (5 00:30 -0800) | ||
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | |
| Mon, 5 Mar 2007 15:57:53 +0000 (5 07:57 -0800) | ||
| tree | bb76dd97b16812efa78f546e08d11bd7ed6eefc7 | treesnapshot (tar.gz zip) |
| parent | c6b36e9a3c57b73c7a6bdf787baa55f21195bba9 | commitdiff |
[PATCH] md: fix for raid6 reshape
Recent patch for raid6 reshape had a change missing that showed up in
subsequent review.
Many places in the raid5 code used "conf->raid_disks-1" to mean "number of
data disks". With raid6 that had to be changed to "conf->raid_disk -
conf->max_degraded" or similar. One place was missed.
This bug means that if a raid6 reshape were aborted in the middle the
recorded position would be wrong. On restart it would either fail (as the
position wasn't on an appropriate boundary) or would leave a section of the
array unreshaped, causing data corruption.
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Recent patch for raid6 reshape had a change missing that showed up in
subsequent review.
Many places in the raid5 code used "conf->raid_disks-1" to mean "number of
data disks". With raid6 that had to be changed to "conf->raid_disk -
conf->max_degraded" or similar. One place was missed.
This bug means that if a raid6 reshape were aborted in the middle the
recorded position would be wrong. On restart it would either fail (as the
position wasn't on an appropriate boundary) or would leave a section of the
array unreshaped, causing data corruption.
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| drivers/md/raid5.c | diffblobblamehistory |