| commit | 5b0c1dd38b66e2dd0cf655aa845e341b50b93ddd | |
| author | Eric W. Biederman <ebiederm@xmission.com> | |
| Mon, 26 Jun 2006 07:25:57 +0000 (26 00:25 -0700) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Mon, 26 Jun 2006 16:58:26 +0000 (26 09:58 -0700) | ||
| tree | e8d3341591958d9c3e11400a2f16287a6dd00c46 | treesnapshot (tar.gz zip) |
| parent | 13b41b09491e5d75e8027dca1ee78f5e073bc4c0 | commitdiff |
[PATCH] proc: optimize proc_check_dentry_visible
The code doesn't need to sleep to when making this check so I can just do the
comparison and not worry about the reference counts.
TODO: While looking at this I realized that my original cleanup did not push
the permission check far enough down into the stack. The call of
proc_check_dentry_visible needs to move out of the generic proc
readlink/follow link code and into the individual get_link instances.
Otherwise the shared resources checks are not quite correct (shared
files_struct does not require a shared fs_struct), and there are races with
unshare.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
The code doesn't need to sleep to when making this check so I can just do the
comparison and not worry about the reference counts.
TODO: While looking at this I realized that my original cleanup did not push
the permission check far enough down into the stack. The call of
proc_check_dentry_visible needs to move out of the generic proc
readlink/follow link code and into the individual get_link instances.
Otherwise the shared resources checks are not quite correct (shared
files_struct does not require a shared fs_struct), and there are races with
unshare.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| fs/proc/base.c | diffblobblamehistory |