inotify: fix race
commit42ee9a96ef6c3b5ac691357737e44fe494070527
authorNick Piggin <npiggin@suse.de>
Wed, 6 Feb 2008 09:37:28 +0000 (6 01:37 -0800)
committerOliver Pinter <oliver.pntr@gmail.com>
Thu, 1 May 2008 13:40:23 +0000 (1 15:40 +0200)
treecc790f7a409f8c2a5737fc425173b31dd418eb47
parent25021d23a79c9d7746f20645a9e260af6ac32879
inotify: fix race

There is a race between setting an inode's children's "parent watched" flag
when placing the first watch on a parent, and instantiating new children of
that parent: a child could miss having its flags set by
set_dentry_child_flags, but then inotify_d_instantiate might still see
!inotify_inode_watched.

The solution is to set_dentry_child_flags after adding the watch.  Locking is
taken care of, because both set_dentry_child_flags and inotify_d_instantiate
hold dcache_lock and child->d_locks.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Robert Love <rlove@google.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: Yan Zheng <yanzheng@21cn.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
fs/inotify.c