| commit | 3d80636a0d5f056ffc26472d05b6027a7a9f6e1c | |
| author | Linus Torvalds <torvalds@g5.osdl.org> | |
| Mon, 17 Oct 2005 00:36:06 +0000 (16 17:36 -0700) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Mon, 17 Oct 2005 00:36:06 +0000 (16 17:36 -0700) | ||
| tree | 39b3dbae53938728c55b2312190561b858431d92 | treesnapshot (tar.gz zip) |
| parent | 688ce17b8599abc548b406c00e4d18ae0dec954f | commitdiff |
Fix memory ordering bug in page reclaim
As noticed by Nick Piggin, we need to make sure that we check the page
count before we check for PageDirty, since the dirty check is only valid
if the count implies that we're the only possible ones holding the page.
We always did do this, but the code needs a read-memory-barrier to make
sure that the orderign is also honored by the CPU.
(The writer side is ordered due to the atomic decrement and test on the
page count, see the discussion on linux-kernel)
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
As noticed by Nick Piggin, we need to make sure that we check the page
count before we check for PageDirty, since the dirty check is only valid
if the count implies that we're the only possible ones holding the page.
We always did do this, but the code needs a read-memory-barrier to make
sure that the orderign is also honored by the CPU.
(The writer side is ordered due to the atomic decrement and test on the
page count, see the discussion on linux-kernel)
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| mm/vmscan.c | diffblobblamehistory |