inotify: fix race
commit045916eb3ea9aec6d3baa18a6649eeb5d252f8bb
authorNick Piggin <npiggin@suse.de>
Wed, 6 Feb 2008 09:37:28 +0000 (6 01:37 -0800)
committerOliver Pinter <oliver.pntr@gmail.com>
Mon, 21 Apr 2008 15:08:07 +0000 (21 17:08 +0200)
tree9ecee8390d2834c2d57fe0ff0761bc5e2f1b5673
parent41fa66104561f5ba4d6ea671f908b3688daacdb3
inotify: fix race

There is a race between setting an inode's children's "parent watched" flag
when placing the first watch on a parent, and instantiating new children of
that parent: a child could miss having its flags set by
set_dentry_child_flags, but then inotify_d_instantiate might still see
!inotify_inode_watched.

The solution is to set_dentry_child_flags after adding the watch.  Locking is
taken care of, because both set_dentry_child_flags and inotify_d_instantiate
hold dcache_lock and child->d_locks.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Robert Love <rlove@google.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: Yan Zheng <yanzheng@21cn.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
fs/inotify.c