From 204df0681400da072116633b1d4368e6aa900d13 Mon Sep 17 00:00:00 2001 From: Glenn Strauss Date: Fri, 28 Oct 2016 14:24:11 -0400 Subject: [PATCH] minor: coverity comments --- src/chunk.c | 1 + src/mod_authn_gssapi.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/chunk.c b/src/chunk.c index 91b3999a..82dab6e0 100644 --- a/src/chunk.c +++ b/src/chunk.c @@ -468,6 +468,7 @@ static chunk *chunkqueue_get_append_tempfile(chunkqueue *cq) { buffer_append_slash(template); buffer_append_string_len(template, CONST_STR_LEN("lighttpd-upload-XXXXXX")); + /* coverity[secure_temp : FALSE] */ if (-1 != (fd = mkstemp(template->ptr))) break; } } else { diff --git a/src/mod_authn_gssapi.c b/src/mod_authn_gssapi.c index 704c66c1..a2afffc0 100644 --- a/src/mod_authn_gssapi.c +++ b/src/mod_authn_gssapi.c @@ -220,7 +220,8 @@ static int mod_authn_gssapi_create_krb5_ccache(server *srv, connection *con, plu buffer * const kccname = buffer_init_string("FILE:/tmp/krb5cc_gssapi_XXXXXX"); char * const ccname = kccname->ptr + sizeof("FILE:")-1; const size_t ccnamelen = buffer_string_length(kccname)-(sizeof("FILE:")-1); - /*(future: might consider using server.upload-dirs instead of /tmp)*/ + /*(future: might consider using server.upload-dirs instead of /tmp)*/ + /* coverity[secure_temp : FALSE] */ int fd = mkstemp(ccname); if (fd < 0) { log_error_write(srv, __FILE__, __LINE__, "ss", "mkstemp():", strerror(errno)); -- 2.11.4.GIT