| commit | 0b4fac6afdd648aa52bb33059e3167fed6eb1353 | |
| author | Eric Blake <eblake@redhat.com> | |
| Mon, 25 Mar 2019 19:46:18 +0000 (25 14:46 -0500) | ||
| committer | Eric Blake <eblake@redhat.com> | |
| Tue, 26 Mar 2019 20:07:47 +0000 (26 15:07 -0500) | ||
| tree | 59a0bf578b8287d692c660ad3481d41ec0a1fa0e | treesnapshot (tar.gz zip) |
| parent | 57d252c7401f981f1caea90250d72e0f87caac19 | commitdiff |
Revert "snapshot: Add virDomainSnapshotObjListFormat"
This reverts commit 86c0ed6f70268dfa7c3bba95a0ba96fcfe2ab039, and
subsequent refactorings of the function into new files. There are no
callers of this function - I had originally proposed it for
implementing a new bulk snapshot API, but that proved to be too
invasive given RPC limits. I also tried using it for streamlining how
the qemu driver stores snapshot state across libvirtd restarts
internally, but in the end, the risks of a new internal format
outweighed the benefits of one file per snapshot.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This reverts commit 86c0ed6f70268dfa7c3bba95a0ba96fcfe2ab039, and
subsequent refactorings of the function into new files. There are no
callers of this function - I had originally proposed it for
implementing a new bulk snapshot API, but that proved to be too
invasive given RPC limits. I also tried using it for streamlining how
the qemu driver stores snapshot state across libvirtd restarts
internally, but in the end, the risks of a new internal format
outweighed the benefits of one file per snapshot.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>