From 1a43d0ed6908adfd86689fae741687c1b57c35e5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Petr=20P=C3=ADsa=C5=99?= Date: Sat, 9 Jan 2010 16:10:02 +0100 Subject: [PATCH] client: computemessagehash: Do not use uninicialized structures --- client/computemessagehash.c | 50 ++++++++++++++++++++------------------------- 1 file changed, 22 insertions(+), 28 deletions(-) diff --git a/client/computemessagehash.c b/client/computemessagehash.c index ad5100e..ce775f3 100644 --- a/client/computemessagehash.c +++ b/client/computemessagehash.c @@ -53,45 +53,39 @@ int main(int argc, char **argv) { else { printf("isds_load_received_message() succeeded:\n"); print_message(message); - } - /* Detach original hash */ - old_hash = message->envelope->hash; - message->envelope->hash = NULL; + /* Detach original hash */ + old_hash = message->envelope->hash; + message->envelope->hash = NULL; - /* Recalculate hash */ - printf("Calculating message hash\n"); - err = isds_compute_message_hash(ctx, message, old_hash->algorithm); - if (err) - printf("isds_compute_message_hash() failed: %s: %s\n", - isds_strerror(err), isds_long_message(ctx)); - else { - printf("isds_compute_message_hash() succeeded:\n"); - print_message(message); - } + /* Recalculate hash */ + printf("Calculating message hash\n"); + err = isds_compute_message_hash(ctx, message, old_hash->algorithm); + if (err) + printf("isds_compute_message_hash() failed: %s: %s\n", + isds_strerror(err), isds_long_message(ctx)); + else { + printf("isds_compute_message_hash() succeeded:\n"); + print_message(message); - printf("Stored hash = "); - print_hash(old_hash); + printf("Stored hash = "); + print_hash(old_hash); - printf("Computed hash = "); - print_hash(message->envelope->hash); + printf("Computed hash = "); + print_hash(message->envelope->hash); - /* Compare hashes */ - compare_hashes(old_hash, message->envelope->hash); - + /* Compare hashes */ + compare_hashes(old_hash, message->envelope->hash); + } + + isds_hash_free(&old_hash); + } - isds_hash_free(&old_hash); isds_message_free(&message); munmap_file(fd, buffer, length); } - err = isds_logout(ctx); - if (err) { - printf("isds_logout() failed: %s\n", isds_strerror(err)); - } - - err = isds_ctx_free(&ctx); if (err) { printf("isds_ctx_free() failed: %s\n", isds_strerror(err)); -- 2.11.4.GIT