From 6bb363e4fb1f4baebc36ef0e98554858d9dddb5b Mon Sep 17 00:00:00 2001 From: tomers Date: Mon, 5 Oct 2009 17:17:30 +0000 Subject: [PATCH] Invert buttons in RTL mode git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22961 a1c6a512-1295-4272-9138-f99709370657 --- apps/action.c | 22 ++++++++++++++++++++++ apps/menus/display_menu.c | 2 +- apps/settings.c | 2 +- firmware/drivers/button.c | 38 ++++++++++++++++++++++++++++++++++---- firmware/export/button.h | 5 ++++- uisimulator/common/stubs.c | 2 +- 6 files changed, 63 insertions(+), 8 deletions(-) diff --git a/apps/action.c b/apps/action.c index ee84706b0..cde57441e 100644 --- a/apps/action.c +++ b/apps/action.c @@ -34,6 +34,9 @@ #include "settings.h" #include "pcmbuf.h" #include "misc.h" +#if defined(HAVE_LCD_BITMAP) && !defined(BOOTLOADER) +#include "language.h" +#endif static int last_button = BUTTON_NONE|BUTTON_REL; /* allow the ipod wheel to work on startup */ @@ -56,6 +59,20 @@ static int unlock_combo = BUTTON_NONE; static bool screen_has_lock = false; #endif /* HAVE_SOFTWARE_KEYLOCK */ +#if defined(HAVE_LCD_BITMAP) && !defined(BOOTLOADER) +/* + * checks whether the given language and context combination require that the + * button is horizontally inverted to support RTL language + * + */ +static bool rtl_button_flip_needed(int context) +{ + return lang_is_rtl() && ((context == CONTEXT_STD) || + (context & CONTEXT_TREE) || (context & CONTEXT_MAINMENU) || + (context & CONTEXT_TREE)); +} +#endif + /* * do_button_check is the worker function for get_default_action. * returns ACTION_UNKNOWN or the requested return value from the list. @@ -201,6 +218,11 @@ static int get_action_worker(int context, int timeout, context &= ~ALLOW_SOFTLOCK; #endif /* HAS_BUTTON_HOLD */ +#if defined(HAVE_LCD_BITMAP) && !defined(BOOTLOADER) + if (rtl_button_flip_needed(context)) + button = button_flip_horizontally(button); +#endif + /* logf("%x,%x",last_button,button); */ while (1) { diff --git a/apps/menus/display_menu.c b/apps/menus/display_menu.c index 5559ecebe..afbb19c60 100644 --- a/apps/menus/display_menu.c +++ b/apps/menus/display_menu.c @@ -67,7 +67,7 @@ static int flipdisplay_callback(int action,const struct menu_item_ex *this_item) switch (action) { case ACTION_EXIT_MENUITEM: - button_set_flip(global_settings.flip_display); + button_set_flip_vertically(global_settings.flip_display); lcd_set_flip(global_settings.flip_display); lcd_update(); #ifdef HAVE_REMOTE_LCD diff --git a/apps/settings.c b/apps/settings.c index ce1ee0705..ac80d1249 100644 --- a/apps/settings.c +++ b/apps/settings.c @@ -846,7 +846,7 @@ void settings_apply(bool read_disk) #endif #ifdef HAVE_LCD_FLIP lcd_set_flip(global_settings.flip_display); - button_set_flip(global_settings.flip_display); + button_set_flip_vertically(global_settings.flip_display); #endif lcd_update(); /* refresh after flipping the screen */ settings_apply_pm_range(); diff --git a/firmware/drivers/button.c b/firmware/drivers/button.c index 71cd4726c..7f3708778 100644 --- a/firmware/drivers/button.c +++ b/firmware/drivers/button.c @@ -437,7 +437,7 @@ void button_close(void) /* * helper function to swap LEFT/RIGHT, UP/DOWN (if present), and F1/F3 (Recorder) */ -static int button_flip(int button) +static int button_flip_vertically(int button) { int newbutton; @@ -507,19 +507,49 @@ static int button_flip(int button) * set the flip attribute * better only call this when the queue is empty */ -void button_set_flip(bool flip) +void button_set_flip_vertically(bool flip) { if (flip != flipped) /* not the current setting */ { /* avoid race condition with the button_tick() */ int oldlevel = disable_irq_save(); - lastbtn = button_flip(lastbtn); + lastbtn = button_flip_vertically(lastbtn); flipped = flip; restore_irq(oldlevel); } } #endif /* HAVE_LCD_FLIP */ +#if defined(HAVE_LCD_BITMAP) && !defined(BOOTLOADER) +/* + * helper function to swap LEFT/RIGHT sides (for RTL mode) + */ +int button_flip_horizontally(int button) +{ + int newbutton; + + newbutton = button & + ~(BUTTON_LEFT | BUTTON_RIGHT +#if defined(BUTTON_SCROLL_BACK) && defined(BUTTON_SCROLL_FWD) + | BUTTON_SCROLL_BACK | BUTTON_SCROLL_FWD +#endif + ); + + if (button & BUTTON_LEFT) + newbutton |= BUTTON_RIGHT; + if (button & BUTTON_RIGHT) + newbutton |= BUTTON_LEFT; +#if defined(BUTTON_SCROLL_BACK) && defined(BUTTON_SCROLL_FWD) + if (button & BUTTON_SCROLL_BACK) + newbutton |= BUTTON_SCROLL_FWD; + if (button & BUTTON_SCROLL_FWD) + newbutton |= BUTTON_SCROLL_BACK; +#endif + + return newbutton; +} +#endif + #ifdef HAVE_BACKLIGHT void set_backlight_filter_keypress(bool value) { @@ -550,7 +580,7 @@ static int button_read(void) #ifdef HAVE_LCD_FLIP if (btn && flipped) - btn = button_flip(btn); /* swap upside down */ + btn = button_flip_vertically(btn); /* swap upside down */ #endif /* HAVE_LCD_FLIP */ #ifdef HAVE_TOUCHSCREEN diff --git a/firmware/export/button.h b/firmware/export/button.h index 3aac1af9d..2e75c573d 100644 --- a/firmware/export/button.h +++ b/firmware/export/button.h @@ -42,7 +42,10 @@ int button_status_wdata(int *pdata); #endif void button_clear_queue(void); #ifdef HAVE_LCD_BITMAP -void button_set_flip(bool flip); /* turn 180 degrees */ +void button_set_flip_vertically(bool flip); /* turn 180 degrees */ +#ifndef BOOTLOADER +int button_flip_horizontally(int button); /* for RTL mode */ +#endif #endif #ifdef HAVE_BACKLIGHT void set_backlight_filter_keypress(bool value); diff --git a/uisimulator/common/stubs.c b/uisimulator/common/stubs.c index 2218c497f..cd9e7b8ad 100644 --- a/uisimulator/common/stubs.c +++ b/uisimulator/common/stubs.c @@ -312,7 +312,7 @@ void cpu_sleep(bool enabled) (void)enabled; } -void button_set_flip(bool yesno) +void button_set_flip_vertically(bool yesno) { (void)yesno; } -- 2.11.4.GIT