From a8477ea4415e75761fc6a3c5786570252ffcb1c0 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Fri, 26 Sep 2008 15:37:30 -0400 Subject: [PATCH] Never write a section symbol into the ksplice_symbol name. Signed-off-by: Anders Kaseorg --- kmodsrc/ksplice.c | 3 --- objmanip.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/kmodsrc/ksplice.c b/kmodsrc/ksplice.c index 87d25fc..9b58629 100644 --- a/kmodsrc/ksplice.c +++ b/kmodsrc/ksplice.c @@ -1594,9 +1594,6 @@ static abort_t lookup_symbol(struct ksplice_pack *pack, return add_candidate_val(pack, vals, lv->val); } - if (starts_with(ksym->label, ".rodata.str")) - return OK; - #ifdef CONFIG_MODULE_UNLOAD if (strcmp(ksym->label, "cleanup_module") == 0 && pack->target != NULL && pack->target->exit != NULL) { diff --git a/objmanip.c b/objmanip.c index 7976a78..2b42710 100644 --- a/objmanip.c +++ b/objmanip.c @@ -1189,7 +1189,7 @@ void write_ksplice_symbol(struct supersect *ss, } else { asymbol *gsym = canonical_symbol(ss->parent, sym); - if (gsym == NULL) + if (gsym == NULL || (gsym->flags & BSF_SECTION_SYM) != 0) ksymbol->name = NULL; else write_string(ksymbol_ss, &ksymbol->name, "%s", -- 2.11.4.GIT