From 976d715ac52a3c54cbc397d22127e773f977e0db Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marc=20V=C3=A9ron?= Date: Wed, 16 Dec 2015 16:00:15 +0100 Subject: [PATCH] Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expected Signed-off-by: Lucio Moraes Signed-off-by: Jonathan Druart Amended patch: I have remove the double if CAN_user_circulate_circulate_remaining_permissions statement (and group block into one). And also remove unecessary change ('IF a IF b' instead of existing 'IF a && b') Signed-off-by: Kyle M Hall --- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 30 ++++++++++++++-------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 6393a046a6..f545afac23 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -63,10 +63,12 @@