From 8e72fc1dfafa4a600612e2139811c63379241cc4 Mon Sep 17 00:00:00 2001 From: Lari Taskula Date: Mon, 10 Oct 2016 17:06:07 +0300 Subject: [PATCH] Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl members/moremember.pl will set mobile number as smsalertnumber in template if smsalertnumber is not defined. This will cause incorrect display for SMS number in patron's Details-tab. This confusion between smsalertnumber and mobile is already fixed in Bug 14683, but members/moremember.pl was not fixed yet. This is a minor issue since it won't occur for manually added new patrons due to fixes already pushed in Bug 14683, but in case patron's smsalertnumber is null in database, this bug can be replicated: To test: 1. Set EnhancedMessagingPreferences to "Allow" and make sure SMSSendDriver has been set. 2. Add a new patron, give it a mobile/other phone number. 3. Run a SQL query: update koha.borrowers set smsalertnumber=NULL where borrowernumber=XXX; (replace XXX with your new patron's borrowernumber) 4. Go to patron's details tab and observe that SMS number shows the mobile/ other phone you provided earlier. 5. Apply patch. 6. Refresh patron's details tab. 7. Observe that smsalertnumber is now empty, as it should be. Followed test plan, works as expected. Signed-off-by: Marc Signed-off-by: Katrin Fischer Signed-off-by: Mason James --- members/moremember.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/moremember.pl b/members/moremember.pl index e7c54f4f06..d5455c0e4d 100755 --- a/members/moremember.pl +++ b/members/moremember.pl @@ -313,7 +313,7 @@ if (C4::Context->preference('EnhancedMessagingPreferences')) { C4::Form::MessagingPreferences::set_form_values({ borrowernumber => $borrowernumber }, $template); $template->param(messaging_form_inactive => 1); $template->param(SMSSendDriver => C4::Context->preference("SMSSendDriver")); - $template->param(SMSnumber => defined $data->{'smsalertnumber'} ? $data->{'smsalertnumber'} : $data->{'mobile'}); + $template->param(SMSnumber => $data->{'smsalertnumber'}); $template->param(TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification")); } -- 2.11.4.GIT