From 5d36a311fe7dfcd99fd4ac31abca606cc815b280 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 14 Apr 2020 17:50:58 -0300 Subject: [PATCH] Bug 25032: Chomp stringified exception If we catch a Koha::Exception-derived exception, the log is put in a single line. If the code 'dies' then a newline character is appended to the string. This patch chomps it so it displays in a single line. To test: 1. Tweak Koha::REST::V1::Cities::list in the try block so it dies before render 2. Restart plack and try the original test plan => FAIL: Notice two lines are logged 3. Apply this patch 4. Repeat 2 => SUCCESS: Only one line in the logs 5. Verify rendering a Koha::Exception works as well: Koha::Exceptions::Exception->throw("Nada!"); Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize --- Koha/REST/Plugin/Exceptions.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Koha/REST/Plugin/Exceptions.pm b/Koha/REST/Plugin/Exceptions.pm index 4539b847aa..9e5c5e5727 100644 --- a/Koha/REST/Plugin/Exceptions.pm +++ b/Koha/REST/Plugin/Exceptions.pm @@ -64,7 +64,10 @@ sub register { $type = "(" . ref($exception) . ")"; } - my $message = "$method $path: unhandled exception $type\<\<$exception\>\>"; + my $exception_string = "$exception"; + chomp($exception_string); + + my $message = "$method $path: unhandled exception $type\<\<$exception_string\>\>"; $c->app->log->error("$message"); -- 2.11.4.GIT