Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred
commitfbd0bbf98f574a7eb804673978a198eea6fdd798
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 11 Nov 2020 13:55:27 +0000 (11 14:55 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 12 Nov 2020 16:09:49 +0000 (12 17:09 +0100)
tree77f2611a46943d32bc9ef830647b8769719b234f
parent1dadf8823357573b740b0c259f16cf18ab4e8904
Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred

There is a missing parameter to CanItemBeReserved, we need to know if
the hold can be placed at a given pickup library.

Test plan:
1 - Set preferences:
     UseBranchTransferLimits: enforce
     BranchTransferLimitsType: itype
     AllowHoldPolicyOverride: Don't allow
2 - Set Centerville 'Book' items to not be allowed to transfer to any other library
3 - Make sure Hold policy is set to 'any library'
4 - Find a record with a Centerville item and other items
5 - Attempt to place an item level hold on the Centerville item (with a
pickup library different than Centerville)
=> Without this patch you are taken to the holds list, but your hold is not placed
Nothing indicates why hold has failed
=> With this patch you cannot select the item from Centerville
"Cannot be transferred to pickup library"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
reserve/request.pl