Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled
commitea09ef36e84e0f217b1c071f110089fddb1a311c
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 12 Feb 2020 14:49:17 +0000 (12 15:49 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 19 Feb 2020 11:12:40 +0000 (19 11:12 +0000)
tree826186c476817aaffce02bdb5ebc0c1da3ec0b28
parent29c09991e7d7e4a00ba18163d28e9545bd4325ce
Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled

If the showLastPatron syspref is disabled, we should not store the 3
cookies we use for this feature.

Test plan:
0/ Do not apply this patch
1/ Turn off showLastPatron
2/ Search for a patron, click on a result
3/ Open the cookie list of your browser
=> You see 3 cookies named lastborrowercard, lastborrowername,
lastborrowernumber
4/ Remove them
5/ Apply the patch
6/ Reload the patron detail page
=> The 3 cookies are not created
7/ Turn the pref on
8/ Reload the patron detail page
=> The 3 cookies are created
9/ Eat one of them.

QA note: it's a bit dirty, we should do that JS side, but
staff-global.js is too widely used to make the change easy. Any other
suggestions welcomed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc