| commit | def50e034d0529be75641b1b0bf8b6ba8d69c12d | |
| author | Jonathan Druart <jonathan.druart@bugs.koha-community.org> | |
| Mon, 15 Oct 2018 13:45:55 +0000 (15 10:45 -0300) | ||
| committer | Martin Renvoize <martin.renvoize@ptfs-europe.com> | |
| Tue, 24 Mar 2020 11:29:45 +0000 (24 11:29 +0000) | ||
| tree | c354df3039c801f07f60ed5041f4a5f0292540d8 | treesnapshot (tar.gz zip) |
| parent | 2e90a02fdd63be5693b481b9bdd08bf0e4c52885 | commitdiff |
Bug 21503: Tests cleanup and highlight a missing case
This patch does the following changes:
- Use build_object to create the MSS
- Store the generate AVs. That was not the case before and so we were
not testing the right things
- Split the tests into 2 parts: staff and OPAC, for readability
- Update the tests' descriptions
- Highlight a problem: If descriptions are missing for both OPAC and
staff, undef is returned. Is that what we expect? It seems that it is
not what were expecting the tests.
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This patch does the following changes:
- Use build_object to create the MSS
- Store the generate AVs. That was not the case before and so we were
not testing the right things
- Split the tests into 2 parts: staff and OPAC, for readability
- Update the tests' descriptions
- Highlight a problem: If descriptions are missing for both OPAC and
staff, undef is returned. Is that what we expect? It seems that it is
not what were expecting the tests.
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
| t/db_dependent/Template/Plugin/AuthorisedValues.t | diffblobblamehistory |