| commit | da1443882cef1e02e9fc1a139bcbeb717519e507 | |
| author | Sophie Meynieux <sophie.meynieux@biblibre.com> | |
| Tue, 13 Aug 2013 16:14:21 +0000 (13 18:14 +0200) | ||
| committer | Tomas Cohen Arazi <tomascohen@gmail.com> | |
| Wed, 20 Nov 2013 14:19:45 +0000 (20 11:19 -0300) | ||
| tree | f427f62f41915056b057a478d0078e89ffc6bab3 | treesnapshot (tar.gz zip) |
| parent | 6229c2b2db34d08dbf40fbf3f376bc836060aa93 | commitdiff |
Bug 10720: fix issue that prevented use of HTML tags in overdue notices
Substitution term in overdue notices shouldn't be removed if they don't match.
It prevents use of HTML in notices to use with CSS.
Test plan :
- define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css
- find a borrower with overdues that trigger this notice
- run overdue_notices.pl -html <directory>
Without patch, your html tags are missing in your html file
With the patch, they are present and can be used with a css to generate a formatted pdf file.
If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template.
Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 394be84dcd65a4569d0467bc12b99dbd6341fc43)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Substitution term in overdue notices shouldn't be removed if they don't match.
It prevents use of HTML in notices to use with CSS.
Test plan :
- define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css
- find a borrower with overdues that trigger this notice
- run overdue_notices.pl -html <directory>
Without patch, your html tags are missing in your html file
With the patch, they are present and can be used with a css to generate a formatted pdf file.
If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template.
Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 394be84dcd65a4569d0467bc12b99dbd6341fc43)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
| misc/cronjobs/overdue_notices.pl | diffblobblamehistory |