| commit | d027e4dcd6264c908ffbf2b5e170e813ab48e081 | |
| author | Colin Campbell <colin.campbell@ptfs-europe.com> | |
| Thu, 8 Apr 2010 12:28:40 +0000 (8 13:28 +0100) | ||
| committer | Colin Campbell <colin.campbell@ptfs-europe.com> | |
| Thu, 8 Apr 2010 12:28:40 +0000 (8 13:28 +0100) | ||
| tree | 6b1aa317fab6f9f370563206464f1d8f98c0bd30 | treesnapshot (tar.gz zip) |
| parent | 3b137922a06e735036b31728e2905f3c3bed0da4 | commitdiff |
add warnings to Serials.pm
Change obvious warning generators:
( use of string comparisons in numeric comparison)
( declaration of variable in comnditional )
also some errors caused by undefined values:
abouttoexpire was not checking for undef values
Pass a valid planneddate in generation of next expected
(undef here causes odd results)
Add a basic test script
test is minimal but I fell over a bug this would have caught
Change obvious warning generators:
( use of string comparisons in numeric comparison)
( declaration of variable in comnditional )
also some errors caused by undefined values:
abouttoexpire was not checking for undef values
Pass a valid planneddate in generation of next expected
(undef here causes odd results)
Add a basic test script
test is minimal but I fell over a bug this would have caught
| C4/Serials.pm | diffblobblamehistory | |
| t/Serials.t | [new file with mode: 0644] | blob |